[SourceKit] Mark overridable declarations as dynamic #74080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
bnbarham
reviewed
Jun 2, 2024
| @@ -0,0 +1,12 @@ | |||
| protocol MyProto { | |||
| // RUN: %sourcekitd-test -req=cursor -pos=%(line + 1):9 %s -- %s | |||
We only set `isDynamic` to `true` if we were inside an expression. Also set `isDynamic` when we are performing cursor info at an overridable declaration. This allows jump-to-definition to jump to declarations that override the one that we performed cursor info on. rdar://128300752
ahoppen
force-pushed
the
dynamic-cursor-info-on-decl
branch
from
238c1e1 to
a38e7cc
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
hamishknight
approved these changes
Jun 3, 2024
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Jun 17, 2024
…hain does not mark overridable function declarations as dynamic This test requires swiftlang/swift#74080 and should be skipped if the host toolchain does not have that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only set
isDynamictotrueif we were inside an expression. Also setisDynamicwhen we are performing cursor info at an overridable declaration. This allows jump-to-definition to jump to declarations that override the one that we performed cursor info on.rdar://128300752